Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24049 )
Change subject: POC IMPALA-14805: LocalIcebergTable loads files in coordinator ...................................................................... Patch Set 7: (7 comments) Overall, seems like a great start. http://gerrit.cloudera.org:8080/#/c/24049/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24049/7//COMMIT_MSG@15 PS7, Line 15: This assumes that local catalog mode is used, I didn't : test without it. To move out of PoC, will need some validation to ensure local catalog mode is used when load_iceberg_files_in_coordinator == true http://gerrit.cloudera.org:8080/#/c/24049/7/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/24049/7/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@1265 PS7, Line 1265: oon Nit: one http://gerrit.cloudera.org:8080/#/c/24049/7/fe/src/main/java/org/apache/impala/catalog/local/IcebergMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/IcebergMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/24049/7/fe/src/main/java/org/apache/impala/catalog/local/IcebergMetaProvider.java@570 PS7, Line 570: // TODO: does it make sense to skip file loading here? Where else would file loading be skipped if not here? http://gerrit.cloudera.org:8080/#/c/24049/7/fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java: http://gerrit.cloudera.org:8080/#/c/24049/7/fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java@169 PS7, Line 169: public class CachedIcebergFiles { Nit: This class definition should be in its own file. http://gerrit.cloudera.org:8080/#/c/24049/7/fe/src/main/java/org/apache/impala/catalog/local/MultiMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/MultiMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/24049/7/fe/src/main/java/org/apache/impala/catalog/local/MultiMetaProvider.java@219 PS7, Line 219: // TODO: this doesn't really make sense It might not right now, but in the future it could. The `tryAllProviders` function would need to ignore `NotImplementedException` or else `DirectMetaProvider#getIcebergContentFileStore` needs to throw a `MetaProviderException` http://gerrit.cloudera.org:8080/#/c/24049/7/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/24049/7/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7804 PS7, Line 7804: // TODO is affectedExistingPartitions needed? Does not seem like it is needed. http://gerrit.cloudera.org:8080/#/c/24049/7/fe/src/test/java/org/apache/impala/catalog/local/MetaProviderDecoratorTest.java File fe/src/test/java/org/apache/impala/catalog/local/MetaProviderDecoratorTest.java: http://gerrit.cloudera.org:8080/#/c/24049/7/fe/src/test/java/org/apache/impala/catalog/local/MetaProviderDecoratorTest.java@142 PS7, Line 142: // TODO: different result if loadFiles=false? It would be trivial to test by adding: // Test loadIcebergTable(TableMetaRef, false) TPartialTableInfo actualIcebergTableInfo = fixture.loadIcebergTable(expectedTableRef, false); assertThat(actualIcebergTableInfo, sameInstance(expectedIcebergTableInfo)); verify(mockDecorated).loadIcebergTable(eq(expectedTableRef), eq(false)); -- To view, visit http://gerrit.cloudera.org:8080/24049 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6732af76a2e040fa57e39260302951466037b934 Gerrit-Change-Number: 24049 Gerrit-PatchSet: 7 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 23 Mar 2026 21:06:18 +0000 Gerrit-HasComments: Yes
