Jason Fehr has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24043 )

Change subject: IMPALA-14432: Upgrade Calcite version to v1.41
......................................................................


Patch Set 4:

(2 comments)

item

http://gerrit.cloudera.org:8080/#/c/24043/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24043/4//COMMIT_MSG@9
PS4, Line 9: The following changes were needed to upgrade Calcite to v1.41:
A large portion of the test changes involved differences in casting decimals.  
Please add an item to this commit message explaining why that change happened 
(e.g. was it a change in how Calcite works with decimal types).


http://gerrit.cloudera.org:8080/#/c/24043/4/testdata/workloads/functional-planner/queries/PlannerTest/calcite/limit-pushdown-analytic-calcite.test
File 
testdata/workloads/functional-planner/queries/PlannerTest/calcite/limit-pushdown-analytic-calcite.test:

http://gerrit.cloudera.org:8080/#/c/24043/4/testdata/workloads/functional-planner/queries/PlannerTest/calcite/limit-pushdown-analytic-calcite.test@614
PS4, Line 614: 1E+1
I'm concerned about breaking profile analysis tools that expect decimal 
notation.  Is there any way to output decimal instead of scientific notation?



--
To view, visit http://gerrit.cloudera.org:8080/24043
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fde6381c04958d69f1bee13864c11c7cd385d29
Gerrit-Change-Number: 24043
Gerrit-PatchSet: 4
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Comment-Date: Tue, 24 Mar 2026 16:53:22 +0000
Gerrit-HasComments: Yes

Reply via email to