Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10788 )
Change subject: Patch llvm to fix run-clang-tidy.py output ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/10788/2/functions.sh File functions.sh: http://gerrit.cloudera.org:8080/#/c/10788/2/functions.sh@210 PS2, Line 210: function setup_extracted_package_build() { > A brief comment would be good (maybe explain how it differes from setup_pac Added comment here and modified the comment for setup_package_build to note that it is a wrapper around this function. http://gerrit.cloudera.org:8080/#/c/10788/2/source/llvm/llvm-5.0.1-patches/0001-PATCH-Fix-run-clang-tidy.py-s-output.patch File source/llvm/llvm-5.0.1-patches/0001-PATCH-Fix-run-clang-tidy.py-s-output.patch: PS2: > Would be nice to get this upstream so we don't have to carry it around with I'm looking at the upstream stuff and it seems like the fixes would still apply. I will look into it. -- To view, visit http://gerrit.cloudera.org:8080/10788 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9125cb0a908fd7005ee68aafb41f3afe93522632 Gerrit-Change-Number: 10788 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 21 Jun 2018 23:13:34 +0000 Gerrit-HasComments: Yes
