Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24008 )
Change subject: IMPALA-14332: Add X-Request-Id as HttpRequestId attribute on root OTel span ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/24008/7/be/src/transport/THttpServer.cpp File be/src/transport/THttpServer.cpp: http://gerrit.cloudera.org:8080/#/c/24008/7/be/src/transport/THttpServer.cpp@295 PS7, Line 295: string request_id; > Use swap to avoid the copy, and reset the value at the same time. Done http://gerrit.cloudera.org:8080/#/c/24008/7/be/src/transport/THttpServer.cpp@298 PS7, Line 298: > I'm not clear why this needs to be reset now. Do we end up with it bleeding Reset is necessary because THttpServer instances are reused across multiple HTTP requests. Also follows the same pattern as the origin_ handling just above it. -- To view, visit http://gerrit.cloudera.org:8080/24008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e14f5b503ff7379463332bae34c266afc395524 Gerrit-Change-Number: 24008 Gerrit-PatchSet: 8 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 27 Mar 2026 04:04:42 +0000 Gerrit-HasComments: Yes
