Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10762 )
Change subject: IMPALA-5873: Check for existence of sync_file_range() ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10762/1/be/src/kudu/util/env_posix.cc File be/src/kudu/util/env_posix.cc: http://gerrit.cloudera.org:8080/#/c/10762/1/be/src/kudu/util/env_posix.cc@757 PS1, Line 757: defined(HAVE_SYNC_FILE_RANGE) > Applicable to Kudu too ?! Looks to me like we could add it there. Kudu doesn't seem to use these cmake-defines, but we could add that functionality. This was a change done by yourself: https://gerrit.cloudera.org/#/c/7923/ Do you recall why we didn't push it upstream? -- To view, visit http://gerrit.cloudera.org:8080/10762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4f9409ca3a519b8b9eb5ca91a3c2a6c7c25e34f Gerrit-Change-Number: 10762 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Comment-Date: Fri, 22 Jun 2018 00:36:10 +0000 Gerrit-HasComments: Yes
