Balazs Hevele has posted comments on this change. ( http://gerrit.cloudera.org:8080/24132 )
Change subject: IMPALA-14851: Codegen GroupingAggregator::CopyGroupingValues ...................................................................... Patch Set 7: (1 comment) Thank you for taking a look at this. So far, only gerrit-verify-dryrun was run on Patch Set 5 to verify correctness. http://gerrit.cloudera.org:8080/#/c/24132/6/be/src/exec/grouping-aggregator-ir.cc File be/src/exec/grouping-aggregator-ir.cc: http://gerrit.cloudera.org:8080/#/c/24132/6/be/src/exec/grouping-aggregator-ir.cc@337 PS6, Line 337: // Instantiate required templates. : template Status GroupingAggregator::AddBatchImpl<false>( : RowBatch*, TPrefetchMode::type, HashTableCtx*, bool); : t > It seems this never being used? Thank you for catching this. This remained in the patch by mistake. -- To view, visit http://gerrit.cloudera.org:8080/24132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2c54a5745ba05a926795318d3b074fde6d0c00a Gerrit-Change-Number: 24132 Gerrit-PatchSet: 7 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 02 Apr 2026 06:21:31 +0000 Gerrit-HasComments: Yes
