Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24161 )
Change subject: IMPALA-14855: Make number of query map shards configurable ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/24161/1/be/src/util/sharded-query-map-util.cc File be/src/util/sharded-query-map-util.cc: http://gerrit.cloudera.org:8080/#/c/24161/1/be/src/util/sharded-query-map-util.cc@30 PS1, Line 30: DEFINE_validator(num_query_map_shards, [](const char* name, uint32_t value) { : if (value == 0) { : std::cerr << "Invalid value for --" << name << ": " << value : << " (must be > 0)" << std::endl; : return false; : } : return true; : }); > There are a few validators in `util/gflag-validator-util.h`, including `ge_ I'll use gt_zero. There's some other cleanup that would be nice to do; catalog-server.cc defines both gt_0 and ValidatePositiveInt, and I believe both are identical to gt_zero. Also found ValidateBiggerThanZero in jwt-util.cc and several variants in backend-gflag-util.cc. -- To view, visit http://gerrit.cloudera.org:8080/24161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icacb7fc541171546925798c2c652d60052bb774b Gerrit-Change-Number: 24161 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 02 Apr 2026 22:07:20 +0000 Gerrit-HasComments: Yes
