Yida Wu has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21309 )

Change subject: IMPALA-12046: Add profile counter for scan range queueing time 
on disk queues
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21309/4/tests/custom_cluster/test_disk_io_queue.py
File tests/custom_cluster/test_disk_io_queue.py:

http://gerrit.cloudera.org:8080/#/c/21309/4/tests/custom_cluster/test_disk_io_queue.py@39
PS4, Line 39:     query = "select * from functional.alltypes limit 
{0}".format(num_rows)
> Can we add test for the case when data_cache is enabled and used by concurr
The high value was probably because the counter was aggregating the queue time 
for every individual range, meaning overlapping concurrent time. I changed the 
logic in the latest patch to use ConcurrentStopWatch to capture the true 
wall-clock time only for the ranges. I will also add the data_cache concurrent 
test later.



--
To view, visit http://gerrit.cloudera.org:8080/21309
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0cb24db36cd89933c150b88e166e68a3abc7a60
Gerrit-Change-Number: 21309
Gerrit-PatchSet: 6
Gerrit-Owner: Yida Wu <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Mon, 06 Apr 2026 18:39:04 +0000
Gerrit-HasComments: Yes

Reply via email to