Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10766 )
Change subject: KUTIL: Various fixes ...................................................................... Patch Set 5: (8 comments) Please see my inline comments in both PS 4 and 5. http://gerrit.cloudera.org:8080/#/c/10766/4/be/src/gutil/port.h File be/src/gutil/port.h: http://gerrit.cloudera.org:8080/#/c/10766/4/be/src/gutil/port.h@426 PS4, Line 426: // Tell UBSAN to ignore a given function completely. There is no Instead of removing the defines we pull in this update from gutil now. http://gerrit.cloudera.org:8080/#/c/10766/5/be/src/kudu/security/CMakeLists.txt File be/src/kudu/security/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/10766/5/be/src/kudu/security/CMakeLists.txt@94 PS5, Line 94: kudu_test_util We used to exclude this because of its gmock dependency. Now more things depend on it and instead we remove the gmock dependency during the definition of kudu_test_util itself. http://gerrit.cloudera.org:8080/#/c/10766/5/be/src/kudu/util/CMakeLists.txt File be/src/kudu/util/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/10766/5/be/src/kudu/util/CMakeLists.txt@291 PS5, Line 291: #gmock see security/CMakeLists.txt http://gerrit.cloudera.org:8080/#/c/10766/2/be/src/kudu/util/compression/compression_codec.cc File be/src/kudu/util/compression/compression_codec.cc: http://gerrit.cloudera.org:8080/#/c/10766/2/be/src/kudu/util/compression/compression_codec.cc@a30 PS2, Line 30: No longer needed http://gerrit.cloudera.org:8080/#/c/10766/5/be/src/kudu/util/compression/compression_codec.cc File be/src/kudu/util/compression/compression_codec.cc: http://gerrit.cloudera.org:8080/#/c/10766/5/be/src/kudu/util/compression/compression_codec.cc@a31 PS5, Line 31: no longer needed with our current version of snappy http://gerrit.cloudera.org:8080/#/c/10766/4/be/src/kudu/util/env_posix.cc File be/src/kudu/util/env_posix.cc: http://gerrit.cloudera.org:8080/#/c/10766/4/be/src/kudu/util/env_posix.cc@92 PS4, Line 92: #include <sys/ioctl.h> We were lacking one include http://gerrit.cloudera.org:8080/#/c/10766/4/be/src/kudu/util/net/socket.cc File be/src/kudu/util/net/socket.cc: http://gerrit.cloudera.org:8080/#/c/10766/4/be/src/kudu/util/net/socket.cc@248 PS4, Line 248: #ifdef SO_REUSEPORT This flag is not supported on CentOS 5 http://gerrit.cloudera.org:8080/#/c/10766/4/be/src/rpc/rpc-mgr-test-base.h File be/src/rpc/rpc-mgr-test-base.h: http://gerrit.cloudera.org:8080/#/c/10766/4/be/src/rpc/rpc-mgr-test-base.h@41 PS4, Line 41: #include "gen-cpp/rpc_test.pb.h" This include became necessary, I suspect after switching to Protobuf 3. -- To view, visit http://gerrit.cloudera.org:8080/10766 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe259bb155bb00ec50db0299321a0a4338d954bf Gerrit-Change-Number: 10766 Gerrit-PatchSet: 5 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Comment-Date: Fri, 22 Jun 2018 01:21:39 +0000 Gerrit-HasComments: Yes
