Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24088 )
Change subject: IMPALA-14589: Add support for Iceberg V3 default values ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/24088/3/be/src/exec/parquet/hdfs-parquet-scanner.cc File be/src/exec/parquet/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/24088/3/be/src/exec/parquet/hdfs-parquet-scanner.cc@2928 PS3, Line 2928: NeedDataInFile > We could introduce a new method like "FileMetadataUtils::ShouldSkipReadFrom Or: - RequireDataInFile() -> true for partitions, false for default values - CanOmitDataInFile() -> true for partitions, true for default values Feel free to come up with different naming if that is more explanatory. -- To view, visit http://gerrit.cloudera.org:8080/24088 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f1be994a336b30b17b17819091417d777a39be9 Gerrit-Change-Number: 24088 Gerrit-PatchSet: 3 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 09 Apr 2026 10:59:49 +0000 Gerrit-HasComments: Yes
