Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10748 )
Change subject: IMPALA-7180: Pin Impala CDH dependencies ...................................................................... Patch Set 7: Code-Review+2 (1 comment) Had one nit, otherwise LGTM. http://gerrit.cloudera.org:8080/#/c/10748/7/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: http://gerrit.cloudera.org:8080/#/c/10748/7/bin/bootstrap_toolchain.py@436 PS7, Line 436: if os.getenv("DOWNLOAD_CDH_COMPONENTS", "false") == "true": nit: you can invert the check (not os.get... == "true") and exit early. That'll reduce the nesting for the rest -- To view, visit http://gerrit.cloudera.org:8080/10748 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I66c0dcb8abdd0d187490a761f129cda3b3500990 Gerrit-Change-Number: 10748 Gerrit-PatchSet: 7 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Fri, 22 Jun 2018 16:29:14 +0000 Gerrit-HasComments: Yes
