Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24177 )
Change subject: `WIP IMPALA-14806: Cache IcebergContentFileStore ...................................................................... Patch Set 5: (7 comments) thanks for the comments, fixed them The patch is still wip due to testLoadIcebergFileDescriptors needing an udpate, but other parts are reciewable http://gerrit.cloudera.org:8080/#/c/24177/3/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/24177/3/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@1241 PS3, Line 1241: IcebergContentFileStoreCacheKey cacheKey = > line too long (93 > 90) Done http://gerrit.cloudera.org:8080/#/c/24177/3/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@2383 PS3, Line 2383: ring Iceberg files > MetaProvider.CachedIcebergFiles? Done http://gerrit.cloudera.org:8080/#/c/24177/3/fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java: http://gerrit.cloudera.org:8080/#/c/24177/3/fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java@177 PS3, Line 177: th > nit: indentation is off Done http://gerrit.cloudera.org:8080/#/c/24177/3/fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java@184 PS3, Line 184: loadIcebergContentFileStore( > nit: fits earlier line Done http://gerrit.cloudera.org:8080/#/c/24177/3/fe/src/main/java/org/apache/impala/catalog/local/MetaProviderDecorator.java File fe/src/main/java/org/apache/impala/catalog/local/MetaProviderDecorator.java: http://gerrit.cloudera.org:8080/#/c/24177/3/fe/src/main/java/org/apache/impala/catalog/local/MetaProviderDecorator.java@159 PS3, Line 159: loadIcebergContentFileStore( > nit: fits line above Done http://gerrit.cloudera.org:8080/#/c/24177/3/fe/src/main/java/org/apache/impala/catalog/local/MultiMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/MultiMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/24177/3/fe/src/main/java/org/apache/impala/catalog/local/MultiMetaProvider.java@217 PS3, Line 217: this interface doesn't really > Could you please elaborate? created ticket IMPALA-14892 http://gerrit.cloudera.org:8080/#/c/24177/3/fe/src/main/java/org/apache/impala/catalog/local/MultiMetaProvider.java@220 PS3, Line 220: loadIcebergContentFileStore( > nit: fits line above Done -- To view, visit http://gerrit.cloudera.org:8080/24177 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic93eeb3a90a280a7138672affd71ac6f87df71a1 Gerrit-Change-Number: 24177 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 15 Apr 2026 14:20:00 +0000 Gerrit-HasComments: Yes
