Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10749 )
Change subject: IMPALA-7140 (part 5): support fetching file info for FS tables ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/10749/2/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java File fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java: http://gerrit.cloudera.org:8080/#/c/10749/2/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@132 PS2, Line 132: FileStatus fileStatus) { > nit: pull up to prev. line. thx for cleaning that signature. Done http://gerrit.cloudera.org:8080/#/c/10749/2/fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/10749/2/fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java@167 PS2, Line 167: must path > Path must be oops, I typed with a lisp there :) http://gerrit.cloudera.org:8080/#/c/10749/2/fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java@172 PS2, Line 172: b.add(it.next()); > nit: one line Done http://gerrit.cloudera.org:8080/#/c/10749/2/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java: http://gerrit.cloudera.org:8080/#/c/10749/2/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java@81 PS2, Line 81: hostIndex_ > pls add a comment and todo to maintain it (afaict, it remains empty). I think this gets modified as a side effect of loadFileDescriptors, which calls HdfsTable.createFileDescriptors, which updates the host index to include all referenced hosts. I'll add some comment. http://gerrit.cloudera.org:8080/#/c/10749/2/fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java: http://gerrit.cloudera.org:8080/#/c/10749/2/fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java@73 PS2, Line 73: Load files and locations > This is more like inode info (file metadata), which is clearer than "Load f Done -- To view, visit http://gerrit.cloudera.org:8080/10749 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42d67ab754872fad094c7dacdd2e1182de1bf3e8 Gerrit-Change-Number: 10749 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Fri, 22 Jun 2018 17:10:50 +0000 Gerrit-HasComments: Yes
