Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10735 )
Change subject: IMPALA-7140 (part 4): support creating descriptors for FS tables ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/10735/3/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java: http://gerrit.cloudera.org:8080/#/c/10735/3/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java@175 PS3, Line 175: /*includeFileDesc=*/false, > I inlined this call into the above function since it was the only call site actually was wrong about this, thrift *descriptors* never include file info. But I think that's already implied by the name "descriptor". Let me know if you want me to add a comment though. -- To view, visit http://gerrit.cloudera.org:8080/10735 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4550612eb6d1e3a324f49a9c4d24b048e45d3738 Gerrit-Change-Number: 10735 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Fri, 22 Jun 2018 17:24:19 +0000 Gerrit-HasComments: Yes
