anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 )
Change subject: IMPALA-4848: Add WIDTH_BUCKET() function ...................................................................... Patch Set 16: (3 comments) http://gerrit.cloudera.org:8080/#/c/6023/15/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/6023/15/be/src/exprs/expr-test.cc@582 PS15, Line 582: > Can you document briefly what the function does? Done http://gerrit.cloudera.org:8080/#/c/6023/15/be/src/exprs/expr-test.cc@587 PS15, Line 587: void TestError(const string& expr) { > ASSERT_FALSE(status.ok()) Done http://gerrit.cloudera.org:8080/#/c/6023/15/be/src/exprs/expr-test.cc@588 PS15, Line 588: GetValue(expr, INVALID_TYPE, /* expect_error */ true); > This is basically EndsWith(), right? Can you factor out into a utility in S Done -- To view, visit http://gerrit.cloudera.org:8080/6023 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I081bc916b1bef7b929ca161a9aade3b54c6b858f Gerrit-Change-Number: 6023 Gerrit-PatchSet: 16 Gerrit-Owner: anujphadke <apha...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-Comment-Date: Fri, 22 Jun 2018 23:39:58 +0000 Gerrit-HasComments: Yes
