Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24279 )
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/24279/2/be/src/exec/blocking-join-node.h File be/src/exec/blocking-join-node.h: http://gerrit.cloudera.org:8080/#/c/24279/2/be/src/exec/blocking-join-node.h@287 PS2, Line 287: if (UseSeparateBuild(state->query_options()) && !waited_for_build_) { > Why recalculate separate_build here? None of the prior implementations did. Oops! I had some back and forth during development about whether this should be one function or two. This is just a relic of when it was two functions. I'll fix it. http://gerrit.cloudera.org:8080/#/c/24279/1/tests/custom_cluster/test_tuple_cache.py File tests/custom_cluster/test_tuple_cache.py: http://gerrit.cloudera.org:8080/#/c/24279/1/tests/custom_cluster/test_tuple_cache.py@719 PS1, Line 719: > flake8: E501 line too long (98 > 90 characters) Done -- To view, visit http://gerrit.cloudera.org:8080/24279 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d Gerrit-Change-Number: 24279 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 06 May 2026 23:54:07 +0000 Gerrit-HasComments: Yes
