Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24238 )
Change subject: IMPALA-14589: [Part 2] Add comprehensive type support for Iceberg initial-default values ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/24238/4/fe/src/main/java/org/apache/impala/util/IcebergSchemaConverter.java File fe/src/main/java/org/apache/impala/util/IcebergSchemaConverter.java: http://gerrit.cloudera.org:8080/#/c/24238/4/fe/src/main/java/org/apache/impala/util/IcebergSchemaConverter.java@320 PS4, Line 320: // Use floor division/mod for handling pre-epoch timestamps. : long seconds = Math.floorDiv(micros, 1_000_000L); : long nanos = Math.floorMod(micros, 1_000_000L) * > Please test how does it work on negative (before epoch) timestamps. Done http://gerrit.cloudera.org:8080/#/c/24238/4/testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-default-values.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-default-values.test: http://gerrit.cloudera.org:8080/#/c/24238/4/testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-default-values.test@259 PS4, Line 259: 'NULL' > I think TIMESTAMPTZ values should be converted to the local timezone. We ca Sure. Done. -- To view, visit http://gerrit.cloudera.org:8080/24238 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c591d5dbf305176dd802c6f5f811c0de98aac0c Gerrit-Change-Number: 24238 Gerrit-PatchSet: 6 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 07 May 2026 07:05:36 +0000 Gerrit-HasComments: Yes
