Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24277 )
Change subject: IMPALA-14952: Fix non-clustering column listing for Iceberg V3 tables ...................................................................... Patch Set 2: (2 comments) Thanks for fixing this! http://gerrit.cloudera.org:8080/#/c/24277/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24277/2//COMMIT_MSG@12 PS2, Line 12: and it causes index out-of-bound error Can we add a regression test for this? http://gerrit.cloudera.org:8080/#/c/24277/2/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/24277/2/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java@202 PS2, Line 202: @Override : public List<Column> getNonClusteringColumns() { : List<Column> cols = super.getNonClusteringColumns(); : if (getFormatVersion() < 3) return cols; : return cols.stream() : .filter(col -> !col.isHidden()) : .collect(Collectors.toList()); : } It's the same in IcebergTable. Can we create a default method in FeIcebergTable? -- To view, visit http://gerrit.cloudera.org:8080/24277 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I341b46737431f090f99c8324a37ba682c45c0df0 Gerrit-Change-Number: 24277 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 07 May 2026 15:45:55 +0000 Gerrit-HasComments: Yes
