Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24159 )
Change subject: [WIP] IMPALA-14863: Fixes Potential OOM During Row Batch Processing ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/24159/7/be/src/udf/udf.cc File be/src/udf/udf.cc: http://gerrit.cloudera.org:8080/#/c/24159/7/be/src/udf/udf.cc@523 PS7, Line 523: if (results_pool_max_mem_ > -1 && UNLIKELY( : results_pool_->total_allocated_bytes() + byte_size > results_pool_max_mem_)) { : results_pool_->Clear(); : } How do we know that there are no references to the memory we are clearing? Could I hit this partway through evaluating a conjunct on a single row? For example with conjunct upper(foo) = upper(bar), could I reach this condition when evaluating upper(bar) and clear the result from upper(foo)? -- To view, visit http://gerrit.cloudera.org:8080/24159 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic54b5c39e1388681275681f22e61b27728dba5af Gerrit-Change-Number: 24159 Gerrit-PatchSet: 7 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Thu, 07 May 2026 21:49:41 +0000 Gerrit-HasComments: Yes
