Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24281 )
Change subject: IMPALA-14958: Fix missing lifecycle events for some nodes ...................................................................... IMPALA-14958: Fix missing lifecycle events for some nodes Node Lifecycle Events in profile are incomplete for KuduScanNodeMt, IcebergMetadataScanNode and SystemTableScanNode. It's fixed by adding the invocation of ScopedOpenEventAdder and ScopedGetNextEventAdder in the corresponding Open and GetNext implementations. Also adds/adjusts the total time counter in some nodes. Testing - Added e2e tests - Improved the timeline checking by verifying all the occurrences. Assisted-by: Composer 2 Change-Id: I39abc3a74df7b4ea3383f104fe1a74ff09f18324 Reviewed-on: http://gerrit.cloudera.org:8080/24281 Reviewed-by: Michael Smith <[email protected]> Reviewed-by: Joe McDonnell <[email protected]> Tested-by: Quanlong Huang <[email protected]> --- M be/src/exec/iceberg-metadata/iceberg-metadata-scan-node.cc M be/src/exec/kudu/kudu-scan-node-mt.cc M be/src/exec/system-table-scan-node.cc M tests/custom_cluster/test_observability.py M tests/query_test/test_observability.py M tests/util/query_profile_util.py 6 files changed, 76 insertions(+), 39 deletions(-) Approvals: Michael Smith: Looks good to me, but someone else must approve Joe McDonnell: Looks good to me, approved Quanlong Huang: Verified -- To view, visit http://gerrit.cloudera.org:8080/24281 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I39abc3a74df7b4ea3383f104fe1a74ff09f18324 Gerrit-Change-Number: 24281 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]>
