Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10720 )
Change subject: IMPALA-6305: Allow column definitions in ALTER VIEW ...................................................................... Patch Set 4: (9 comments) LGTM overall, I just have couple nits and I can give a +1. http://gerrit.cloudera.org:8080/#/c/10720/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10720/3//COMMIT_MSG@26 PS3, Line 26: nit: remove spaces to not overly indented. http://gerrit.cloudera.org:8080/#/c/10720/3/fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java: http://gerrit.cloudera.org:8080/#/c/10720/3/fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java@76 PS3, Line 76: if (columnDefs_ != null) sb.append("(" + Joiner.on(", ").join(columnDefs_) + "."); I don't know if we have an existing test to print the SQL. If we do, we should also update it. http://gerrit.cloudera.org:8080/#/c/10720/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: http://gerrit.cloudera.org:8080/#/c/10720/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@1102 PS3, Line 1102: + nit: + before a new line http://gerrit.cloudera.org:8080/#/c/10720/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@1106 PS3, Line 1106: + nit: + before a new line http://gerrit.cloudera.org:8080/#/c/10720/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@1110 PS3, Line 1110: + nit: + before a new line http://gerrit.cloudera.org:8080/#/c/10720/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@1159 PS3, Line 1159: "sel nit: fix indentation http://gerrit.cloudera.org:8080/#/c/10720/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@1160 PS3, Line 1160: "inn nit: fix indentation http://gerrit.cloudera.org:8080/#/c/10720/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java: http://gerrit.cloudera.org:8080/#/c/10720/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@1660 PS3, Line 1660: AuthzOk("ALTER VIEW functional.alltypes_view (a, b, c) as " + nit: is this a tab character? If yes, please use spaces? http://gerrit.cloudera.org:8080/#/c/10720/3/testdata/workloads/functional-query/queries/QueryTest/views-ddl.test File testdata/workloads/functional-query/queries/QueryTest/views-ddl.test: http://gerrit.cloudera.org:8080/#/c/10720/3/testdata/workloads/functional-query/queries/QueryTest/views-ddl.test@234 PS3, Line 234: comment 'abc' Unfortunately "describe" doesn't show comments. "describe formatted/extended" does. It would be good to be able to verify the updated comments. -- To view, visit http://gerrit.cloudera.org:8080/10720 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6073444a814a24d97e80df15fcd39be2812f63fc Gerrit-Change-Number: 10720 Gerrit-PatchSet: 4 Gerrit-Owner: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Mon, 25 Jun 2018 18:17:57 +0000 Gerrit-HasComments: Yes
