Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23922 )

Change subject: IMPALA-9059: Add UNPIVOT clause
......................................................................


Patch Set 11:

(2 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/23922/11/fe/src/main/java/org/apache/impala/analysis/UnpivotTableRef.java
File fe/src/main/java/org/apache/impala/analysis/UnpivotTableRef.java:

http://gerrit.cloudera.org:8080/#/c/23922/11/fe/src/main/java/org/apache/impala/analysis/UnpivotTableRef.java@223
PS11, Line 223:         // Registers SlotRefs for the names in the UNPIVOT 
clause against the source table.
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/23922/11/tests/query_test/test_unpivot_clause.py
File tests/query_test/test_unpivot_clause.py:

http://gerrit.cloudera.org:8080/#/c/23922/11/tests/query_test/test_unpivot_clause.py@49
PS11, Line 49:
flake8: W292 no newline at end of file



--
To view, visit http://gerrit.cloudera.org:8080/23922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10e9d0a1bd70de02c7998afca274b895055d9b6a
Gerrit-Change-Number: 23922
Gerrit-PatchSet: 11
Gerrit-Owner: Xuebin Su <[email protected]>
Gerrit-Reviewer: Daniel Vanko <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Xuebin Su <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Mon, 11 May 2026 08:53:55 +0000
Gerrit-HasComments: Yes

Reply via email to