Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10704 )
Change subject: IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans ...................................................................... Patch Set 3: I don't think we need to implement all of IMPALA-6874, but I think we should basic test coverage (planner and end-to-end test) to prevent regressions. It would be pretty easy to introduce a bug where: * Parquet predicates get omitted on mixed format tables * Something gets broken with handling of predicates on non-Parquet scanners when we have Parquet conjuncts. It might be sufficient to add a Parquet partition to alltypesmixedformat -- To view, visit http://gerrit.cloudera.org:8080/10704 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d6c26d42db090c8a15c602f6419ad6399c329e7 Gerrit-Change-Number: 10704 Gerrit-PatchSet: 3 Gerrit-Owner: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 25 Jun 2018 21:59:14 +0000 Gerrit-HasComments: No
