Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10811 )
Change subject: IMPALA-7207: make Coordinator::exec_state_ an atomic enum ...................................................................... IMPALA-7207: make Coordinator::exec_state_ an atomic enum That allows us to avoid taking the lock in cases where only the exec_state_ field needs to be read (as opposed to needing to read both exec_state_ and exec_status_). In particular, it avoids the lock on the non-terminating paths, which is the common case. Change-Id: Ie6c5d5c6ccfdfd533cd0607aab6f554e664b90ac Reviewed-on: http://gerrit.cloudera.org:8080/10811 Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/common/atomic.h M be/src/runtime/coordinator.cc M be/src/runtime/coordinator.h M be/src/runtime/fragment-instance-state.h 4 files changed, 19 insertions(+), 20 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10811 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie6c5d5c6ccfdfd533cd0607aab6f554e664b90ac Gerrit-Change-Number: 10811 Gerrit-PatchSet: 4 Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
