Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24247 )
Change subject: IMPALA-14814: Handle implicit casts properly for Calcite Planner ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/24247/4/fe/src/main/java/org/apache/impala/analysis/CastExpr.java File fe/src/main/java/org/apache/impala/analysis/CastExpr.java: http://gerrit.cloudera.org:8080/#/c/24247/4/fe/src/main/java/org/apache/impala/analysis/CastExpr.java@470 PS4, Line 470: protected boolean shouldRemoveImplicitCast() { > Oh right, this should have been a comment on the AnalyzedCastExpr implement Done http://gerrit.cloudera.org:8080/#/c/24247/8/fe/src/main/java/org/apache/impala/analysis/CastExpr.java File fe/src/main/java/org/apache/impala/analysis/CastExpr.java: http://gerrit.cloudera.org:8080/#/c/24247/8/fe/src/main/java/org/apache/impala/analysis/CastExpr.java@72 PS8, Line 72: boolean isImplicit) { > Sure, I think that'd be ok. Done http://gerrit.cloudera.org:8080/#/c/24247/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedCastExpr.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedCastExpr.java: http://gerrit.cloudera.org:8080/#/c/24247/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedCastExpr.java@56 PS8, Line 56: protected boolean shouldRemoveImplicitCast() { > Shouldn't this have an @Override tag? Done -- To view, visit http://gerrit.cloudera.org:8080/24247 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d71357ac7f228404713f96884d9eff7f8eabe5c Gerrit-Change-Number: 24247 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 14 May 2026 03:26:08 +0000 Gerrit-HasComments: Yes
