Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24288 )
Change subject: IMPALA-12679: Deflake rpc_count check in TestFetch.test_rows_sent_counters ...................................................................... IMPALA-12679: Deflake rpc_count check in TestFetch.test_rows_sent_counters The test expects the RPCCount in profile is in range of [5, 9]. However, in parallel e2e tests the cluster is busy. The query needs more time to run into the FINISHED state, which leads to the client (test code) sends more GetOperationStatus RPCs to check the query state. The total number of RPCs could exceed 9. To count the RPCs, this patch improves wait_for_impala_state() to also return the number of state checks that have been performed. Also saves one RPC from get_runtime_profile() by using the runtime_profile in fetch result directly. The expected rpc_count is num_state_checks + 5. The additional 5 RPCs are GetResultSetMetadata, FetchResults * 2, GetLog, GetRuntimeProfile. Note that Impyla (0.21a3) uses two FetchResults RPCs to fetch the results. It doesn't check hasMoreRows=false in the response of the first FetchResults, so sends an additional FetchResults to get an empty batch then stop. Testing - Ran TestFetch.test_rows_sent_counters 20 times. - Ran tests in custom_cluster/test_admission_controller.py and custom_cluster/test_events_custom_configs.py that use wait_for_any_impala_state() Change-Id: Icb790895e4ed31eda0b858fb6f1484eca401af73 Reviewed-on: http://gerrit.cloudera.org:8080/24288 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M tests/common/impala_connection.py M tests/custom_cluster/test_admission_controller.py M tests/custom_cluster/test_events_custom_configs.py M tests/query_test/test_fetch.py 4 files changed, 16 insertions(+), 9 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/24288 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Icb790895e4ed31eda0b858fb6f1484eca401af73 Gerrit-Change-Number: 24288 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]>
