Mihaly Szjatinya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24302 )

Change subject: IMPALA-14987: test_topic_updates_unblock_legacy_catalog is flaky
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24302/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24302/2//COMMIT_MSG@10
PS2, Line 10: Doubling all times proportionally.
> So the test failed with:
The sleep times are for the slow blocking queries.

The key is the change in expected time 'fast_query_timeout_ms=2000' for 
'__run_topic_update_test_inner' method. Everything else is just to preserve the 
original proportions.

In IMPALA-14801, for non-iceberg tests it was merely bugfixing/refactoring. 
Together with new variants and the new Iceberg tests the overall time has 
largely grown up. That's why I reduced all times by the factor of (arbitrary) 
5. But looks like it needs to be rolled back a bit now.


http://gerrit.cloudera.org:8080/#/c/24302/2//COMMIT_MSG@11
PS2, Line 11:
> Please mention how did you reproduce the issue, e.g. "Running the test 100
I'm not able to reproduce it locally, even after 100 tries.

Btw, before IMPALA-14801 there was a comment in code, stating that these fast 
queries take a couple of seconds, but on my environment it's only some 
milliseconds. I thought the comment is incorrect and changed it, but maybe I'm 
missing something.

Do you have an idea what could be an environment difference?



--
To view, visit http://gerrit.cloudera.org:8080/24302
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c1f01de08d4d17972579ead96499adcdb9eb038
Gerrit-Change-Number: 24302
Gerrit-PatchSet: 2
Gerrit-Owner: Mihaly Szjatinya <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Mihaly Szjatinya <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Thu, 14 May 2026 14:13:40 +0000
Gerrit-HasComments: Yes

Reply via email to