Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24304 )
Change subject: IMPALA-14986: Fix test_cancelled_nodes_in_exec_summary ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Couple of nits, but otherwise looks great. http://gerrit.cloudera.org:8080/#/c/24304/2/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/24304/2/tests/query_test/test_observability.py@109 PS2, Line 109: '00:SCAN ' + FILESYSTEM_NAME Nit: These string concats would be better done via string placeholders, but it's not a blocker. "00:SCAN {}".format(FILESYSTEM_NAME). http://gerrit.cloudera.org:8080/#/c/24304/2/tests/query_test/test_observability.py@181 PS2, Line 181: scan_op = 'SCAN ' + FILESYSTEM_NAME Nit: duplicates some of line 109, create a file level constant SCAN_OP -- To view, visit http://gerrit.cloudera.org:8080/24304 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6be78952aa8ba249381440e07213ad1cc124a183 Gerrit-Change-Number: 24304 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 14 May 2026 15:58:08 +0000 Gerrit-HasComments: Yes
