Joe McDonnell has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/24299 )

Change subject: IMPALA-14988: Allow verifying server with default CAs in 
impala-shell
......................................................................

IMPALA-14988: Allow verifying server with default CAs in impala-shell

Before this patch impala-shell either used a custom CA certificate
(--ca_cert) or didn't verify the server at all. Added option
--verify_cert to verify the server using default CA certs (usually
set at OS level).

By default server is still not verified - in the future
it may make sense to switch to more secure default. Meanwhile
impalarc can be used to set verify_cert=true without altering
impala-shell invocations.

Based on https://github.com/cloudera/impyla/pull/601

Testing:
- added negative test to check if self-signed test certs
  are rejected
- no positive test as it is harder to add a self-signed
  test cert to the default CA certs

Generated by Claude Sonnet 4.6

Change-Id: I8375443d080876d0c8489cbe4c27193b5f7f9b4b
Reviewed-on: http://gerrit.cloudera.org:8080/24299
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Michael Smith <[email protected]>
Reviewed-by: Joe McDonnell <[email protected]>
---
M shell/impala_shell/impala_client.py
M shell/impala_shell/impala_shell.py
M shell/impala_shell/impala_shell_config_defaults.py
M shell/impala_shell/option_parser.py
M tests/custom_cluster/test_client_ssl.py
5 files changed, 48 insertions(+), 26 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Michael Smith: Looks good to me, but someone else must approve
  Joe McDonnell: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/24299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8375443d080876d0c8489cbe4c27193b5f7f9b4b
Gerrit-Change-Number: 24299
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>

Reply via email to