Xuebin Su has posted comments on this change. ( http://gerrit.cloudera.org:8080/24105 )
Change subject: IMPALA-2083: Add PIVOT clause ...................................................................... Patch Set 14: (2 comments) > Patch Set 9: > > (7 comments) > > I've done the second round of review. The rewrite solution LGTM. I think we > just need to fix some special cases like nested PIVOT and add more tests like > DMLs. If some special cases are not supported, we need better error messages. > > Thanks for this hard work! Thanks for your reviews! http://gerrit.cloudera.org:8080/#/c/24105/9/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java: http://gerrit.cloudera.org:8080/#/c/24105/9/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@625 PS9, Line 625: if (requiresZippingUnnestRewrite()) { > This also skips DMLs like CreateTableAsSelect, INSERT. I think we should be Thanks! Added. http://gerrit.cloudera.org:8080/#/c/24105/9/fe/src/main/java/org/apache/impala/analysis/PivotTableRef.java File fe/src/main/java/org/apache/impala/analysis/PivotTableRef.java: http://gerrit.cloudera.org:8080/#/c/24105/9/fe/src/main/java/org/apache/impala/analysis/PivotTableRef.java@216 PS9, Line 216: > Just tried nested PIVOT, it doesn't work: Thanks! Fixed. -- To view, visit http://gerrit.cloudera.org:8080/24105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib799b772be18d2a3db8983b24e1068e7dfdf1ca9 Gerrit-Change-Number: 24105 Gerrit-PatchSet: 14 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Fri, 15 May 2026 04:25:31 +0000 Gerrit-HasComments: Yes
