Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24311 )
Change subject: IMPALA-14999: Calcite planner: support Iceberg tables (part 2) ...................................................................... Patch Set 5: (13 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24311/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexLiteralConverter.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexLiteralConverter.java: http://gerrit.cloudera.org:8080/#/c/24311/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexLiteralConverter.java@57 PS5, Line 57: public static Expr getExpr(RexLiteral rexLiteral, Analyzer analyzer) throws AnalysisException { line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/24311/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java: http://gerrit.cloudera.org:8080/#/c/24311/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java@278 PS5, Line 278: // The conjuncts for non-iceberg tables will be handled by the partition pruner and will line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/24311/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java@279 PS5, Line 279: // not be present here. However, Iceberg conjuncts need to be evaluated. Check the Iceberg line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/24311/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java@286 PS5, Line 286: if (!canConvertIcebergPredicate((FeIcebergTable) table.getFeFsTable(), conjunct, analyzer)) { line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/24311/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java: http://gerrit.cloudera.org:8080/#/c/24311/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java@179 PS5, Line 179: return new NodeWithExprs(joinNode, outputExprs, getRowType().getFieldNames(), tableRefs); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/24311/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/IcebergCountStarOptimizer.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/IcebergCountStarOptimizer.java: http://gerrit.cloudera.org:8080/#/c/24311/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/IcebergCountStarOptimizer.java@90 PS5, Line 90: protected static final Logger LOG = LoggerFactory.getLogger(IcebergCountStarOptimizer.class.getName()); line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/24311/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/IcebergCountStarOptimizer.java@132 PS5, Line 132: RexLiteral countLiteral = rexBuilder.makeLiteral(count, ImpalaTypeConverter.getRelDataType(Type.BIGINT)); line too long (109 > 90) http://gerrit.cloudera.org:8080/#/c/24311/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/IcebergCountStarOptimizer.java@144 PS5, Line 144: // For the count(*), we add the input ref to the count literal constant from the v2 count. line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/24311/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/IcebergCountStarOptimizer.java@145 PS5, Line 145: projects.add(rexBuilder.makeCall(ImpalaCustomOperatorTable.PLUS, aggInput, countLiteral)); line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/24311/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/IcebergCountStarOptimizer.java@164 PS5, Line 164: RexLiteral countLiteral = rexBuilder.makeLiteral(count, ImpalaTypeConverter.getRelDataType(Type.BIGINT)); line too long (109 > 90) http://gerrit.cloudera.org:8080/#/c/24311/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/IcebergCountStarOptimizer.java@173 PS5, Line 173: return LogicalValues.create(cluster, agg.getRowType(), ImmutableList.of(ImmutableList.copyOf(literals))); line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/24311/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/IcebergCountStarOptimizer.java@185 PS5, Line 185: LogicalAggregate newAgg = LogicalAggregate.create(agg.getInputs().get(0), agg.getHints(), agg.getGroupSet(), agg.getGroupSets(), nonCountStarAggregates); line too long (159 > 90) http://gerrit.cloudera.org:8080/#/c/24311/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaFilterSimplifyRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaFilterSimplifyRule.java: http://gerrit.cloudera.org:8080/#/c/24311/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaFilterSimplifyRule.java@64 PS5, Line 64: call.transformTo(LogicalValues.create(cluster, filter.getRowType(), ImmutableList.of())); line too long (95 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24311 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1854012b1caac63ced292b338d40074db950b42d Gerrit-Change-Number: 24311 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Sun, 17 May 2026 04:38:09 +0000 Gerrit-HasComments: Yes
