Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24317 )
Change subject: IMPALA-14843: (addendum) fixed broken test for Calcite planner ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/24317/2/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/24317/2/tests/query_test/test_observability.py@a216 PS2, Line 216: > nit: I think this is correct in the original planner so don't need to chang Unfortuantely, Calcite does not have the alias there and I haven't looked into that change to make sure it matches Impala. I put in an extra comment at that line, but I will try to look at this at some point. The check for the original planner still has the alias, of course. http://gerrit.cloudera.org:8080/#/c/24317/2/tests/query_test/test_observability.py@219 PS2, Line 219: HDFS > We should avoid hard coding "HDFS" like this patch fixes: https://gerrit.cl Done http://gerrit.cloudera.org:8080/#/c/24317/2/tests/query_test/test_observability.py@228 PS2, Line 228: e > flake8: E501 line too long (91 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/24317/2/tests/query_test/test_observability.py@231 PS2, Line 231: e > flake8: E501 line too long (91 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/24317/2/tests/query_test/test_observability.py@234 PS2, Line 234: e > flake8: E501 line too long (91 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/24317/2/tests/query_test/test_observability.py@235 PS2, Line 235: e > flake8: E501 line too long (91 > 90 characters) Done -- To view, visit http://gerrit.cloudera.org:8080/24317 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I930a9a2f52dd727388c9e9eb70b6452f8343d4c8 Gerrit-Change-Number: 24317 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Sun, 17 May 2026 16:20:31 +0000 Gerrit-HasComments: Yes
