Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10789 )
Change subject: IMPALA-6425: reduce MemPool max chunk size ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10789/1/be/src/runtime/mem-pool.h File be/src/runtime/mem-pool.h: http://gerrit.cloudera.org:8080/#/c/10789/1/be/src/runtime/mem-pool.h@182 PS1, Line 182: /// a freelist in TCMalloc's central cache. > I wonder if it's better for mem pool to come from global or thread lists. A Yeah that feels like a question we'd need a benchmark to answer - not sure if there would be negative impacts like squeezing smaller allocations out of the thread caches. -- To view, visit http://gerrit.cloudera.org:8080/10789 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58cc3031ce592892cb9efe9ab41f07d86468b08c Gerrit-Change-Number: 10789 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 26 Jun 2018 15:00:33 +0000 Gerrit-HasComments: Yes
