Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21579 )
Change subject: POC: Add queuing to KrpcDataStreamSender ...................................................................... Patch Set 15: (2 comments) http://gerrit.cloudera.org:8080/#/c/21579/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21579/12//COMMIT_MSG@12 PS12, Line 12: 2. in-fligh batch (with current active RPC) > Done in-flight is still missing a 't'. http://gerrit.cloudera.org:8080/#/c/21579/12/be/src/runtime/krpc-data-stream-sender.h File be/src/runtime/krpc-data-stream-sender.h: http://gerrit.cloudera.org:8080/#/c/21579/12/be/src/runtime/krpc-data-stream-sender.h@317 PS12, Line 317: // sending it (QueuedBatch::consumers_left reaches 0). > I didn't think through yet what is the best solution. Using an intrusive li I thought about intrusive list, but since you're allocating QueuedBatch directly in the data structure I don't think it avoids any allocations (and probably has worse cache locality compared to a deque). -- To view, visit http://gerrit.cloudera.org:8080/21579 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe3d01fada31f1b48de6c1403e7d2955114d8078 Gerrit-Change-Number: 21579 Gerrit-PatchSet: 15 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 19 May 2026 16:00:27 +0000 Gerrit-HasComments: Yes
