Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23848 )

Change subject: IMPALA-14942: [tools] Impala devcontainer
......................................................................


Patch Set 12:

(3 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/23848/12/.devcontainer-build/build-devcontainer.sh
File .devcontainer-build/build-devcontainer.sh:

http://gerrit.cloudera.org:8080/#/c/23848/12/.devcontainer-build/build-devcontainer.sh@80
PS12, Line 80: IMPALA_CMAKE_VERSION="$(grep 'export IMPALA_CMAKE_VERSION=' 
"${IMPALA_HOME}/bin/impala-config.sh" | cut -d'=' -f2)"
line too long (115 > 90)


http://gerrit.cloudera.org:8080/#/c/23848/12/.devcontainer-build/build-devcontainer.sh@81
PS12, Line 81: IMPALA_GCC_VERSION="$(grep 'export IMPALA_GCC_VERSION=' 
"${IMPALA_HOME}/bin/impala-config.sh" | cut -d'=' -f2)"
line too long (111 > 90)


http://gerrit.cloudera.org:8080/#/c/23848/12/.devcontainer/regen-ssh-keys.sh
File .devcontainer/regen-ssh-keys.sh:

http://gerrit.cloudera.org:8080/#/c/23848/12/.devcontainer/regen-ssh-keys.sh@38
PS12, Line 38:       -C "Impala-devcontainer-$(date +'%Y-%m-%d_%H:%M:%S') - 
Impala devcontainer '${HOSTNAME}' created '$(date)'" \
line too long (115 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/23848
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6aa834494003619fcdfbd98f3bfc7c74d3e1554c
Gerrit-Change-Number: 23848
Gerrit-PatchSet: 12
Gerrit-Owner: Jason Fehr <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Tue, 19 May 2026 19:47:22 +0000
Gerrit-HasComments: Yes

Reply via email to