Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10705 )
Change subject: IMPALA-6816: minimise calls to GetMinSubscriberTopicVersion() ...................................................................... Patch Set 6: Code-Review+2 (1 comment) Thanks for the review http://gerrit.cloudera.org:8080/#/c/10705/4/tests/statestore/test_statestore.py File tests/statestore/test_statestore.py: http://gerrit.cloudera.org:8080/#/c/10705/4/tests/statestore/test_statestore.py@635 PS4, Line 635: assert min_subscriber_topic_version <= min_to_version,\ > It might save people's time by explicitly mentioning that the assertion is Done -- To view, visit http://gerrit.cloudera.org:8080/10705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ee7cb2355ba1049b9081e0df344ac41aa4ebeb1 Gerrit-Change-Number: 10705 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 26 Jun 2018 20:33:21 +0000 Gerrit-HasComments: Yes
