Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24309 )
Change subject: IMPALA-14999: Calcite planner: support Iceberg tables (part 1) ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/24309/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24309/7//COMMIT_MSG@33 PS7, Line 33: d > nit: typo Done http://gerrit.cloudera.org:8080/#/c/24309/6/fe/src/main/java/org/apache/impala/planner/ScanNodeHelperImpl.java File fe/src/main/java/org/apache/impala/planner/ScanNodeHelperImpl.java: http://gerrit.cloudera.org:8080/#/c/24309/6/fe/src/main/java/org/apache/impala/planner/ScanNodeHelperImpl.java@26 PS6, Line 26: import org.apache.impala.analysis.MultiAggregateInfo; > nit: not used Heh...yeah, this is added in part 2. Moved it to the appropriate commit. http://gerrit.cloudera.org:8080/#/c/24309/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/phys/ImpalaHdfsScanNode.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/phys/ImpalaHdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/24309/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/phys/ImpalaHdfsScanNode.java@63 PS6, Line 63: } > nit: looks like a missing newline Heh, yeah, but prolly shouldn't be there? -- To view, visit http://gerrit.cloudera.org:8080/24309 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba7260194e14d8aeb2df9fe3cb875a0ee8450fb1 Gerrit-Change-Number: 24309 Gerrit-PatchSet: 6 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 22 May 2026 19:02:43 +0000 Gerrit-HasComments: Yes
