Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24345 )
Change subject: IMPALA-14994: Fix data race in destructor of ScopedGetNextEventAdder ...................................................................... IMPALA-14994: Fix data race in destructor of ScopedGetNextEventAdder The last_batch_returned_ boolean flag of ExecNode is written in the fragment instance thread and read by the query state thread in constructing the status reports. This patch changes its type to AtomicBool to fix the data race issue. Note that it's OK if the query state thread sees last_batch_returned_ = false while the fragment instance thread is finishing. The query state thread will send a final status report which reads the final last_batch_returned_ value. Testing - Ran TSAN build Change-Id: Ia3bf17f56974e471994ca889190c7065574a3414 Reviewed-on: http://gerrit.cloudera.org:8080/24345 Reviewed-by: Peter Rozsa <[email protected]> Reviewed-by: Zoltan Borok-Nagy <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/common/atomic.h M be/src/exec/exec-node-util.h M be/src/exec/exec-node.h 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Peter Rozsa: Looks good to me, approved Zoltan Borok-Nagy: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/24345 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia3bf17f56974e471994ca889190c7065574a3414 Gerrit-Change-Number: 24345 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
