Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24337 )
Change subject: IMPALA-14954: [WIP] Support WITH ADMIN OPTION clause for GRANT ROLE ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/24337/2/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: http://gerrit.cloudera.org:8080/#/c/24337/2/fe/src/main/cup/sql-parser.cup@1185 PS2, Line 1185: KW_SHOW KW_CURRENT KW_ROLES : {: RESULT = new ShowRolesStmt(true, null, null); :} : ; > It may make more sense to use ShowRolesPrincipalStmt() below to process SHO It's true that with ShowRolesPrincipalStmt(), we will be able to show if the current effective user is also a role administrator of a given role the user is assigned. But it's possible that the current effective user belongs to 2 groups g_1 and g_2, where the group g_1 is a role administrator of the role r, but the group g_2 is not a role administrator of the role r. How should we deal with this case in SHOW CURRENT ROLES? To not lose this piece of information, we may need 4 columns in the result: role_name, user_name, group_name, and grant_option. Based on the analysis above, it may be better to create a follow-up JIRA to keep track of this so that we could have a more thorough discussion over there. -- To view, visit http://gerrit.cloudera.org:8080/24337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e7c9ba091bc15271c7a3ef34ca06a38630d5bb6 Gerrit-Change-Number: 24337 Gerrit-PatchSet: 2 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 26 May 2026 20:55:11 +0000 Gerrit-HasComments: Yes
