Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24357 )

Change subject: IMPALA-13033: Parse WebUI thrift profile downloads
......................................................................


Patch Set 3:

(1 comment)

Thanks for your contribution! This patch is simpler than the summary support 
patch which is the parent commit. Do you mind rebasing the current patch on to 
master branch so we can merge it first?

http://gerrit.cloudera.org:8080/#/c/24357/3/be/src/util/impala-profile-tool.cc
File be/src/util/impala-profile-tool.cc:

http://gerrit.cloudera.org:8080/#/c/24357/3/be/src/util/impala-profile-tool.cc@544
PS3, Line 544: query_id
query_id can be empty string here. PrintSummaryRow() should get the query_id in 
the profile in such case.

Note: this can be done in the summary support patch.



--
To view, visit http://gerrit.cloudera.org:8080/24357
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2baed77cce3de43ef153b853329ad899f999f473
Gerrit-Change-Number: 24357
Gerrit-PatchSet: 3
Gerrit-Owner: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Thu, 28 May 2026 06:44:52 +0000
Gerrit-HasComments: Yes

Reply via email to