Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24376 )
Change subject: WIP: update TCLIService.thrift ...................................................................... Patch Set 1: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24376/1/common/thrift/hive-1-api/TCLIService.thrift File common/thrift/hive-1-api/TCLIService.thrift: http://gerrit.cloudera.org:8080/#/c/24376/1/common/thrift/hive-1-api/TCLIService.thrift@348 PS1, Line 348: 7: TStringValue stringVal // STRING, LIST, MAP, STRUCT, UNIONTYPE, BINARY, DECIMAL, NULL, INTERVAL_YEAR_MONTH, INTERVAL_DAY_TIME line too long (133 > 90) http://gerrit.cloudera.org:8080/#/c/24376/1/common/thrift/hive-1-api/TCLIService.thrift@573 PS1, Line 573: 1: required TProtocolVersion client_protocol = TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V10 line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/24376/1/common/thrift/hive-1-api/TCLIService.thrift@592 PS1, Line 592: 2: required TProtocolVersion serverProtocolVersion = TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V10 line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/24376/1/common/thrift/hive-1-api/TCLIService.thrift@826 PS1, Line 826: // Retrieves the schema names available in this database. line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/24376 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc Gerrit-Change-Number: 24376 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 28 May 2026 15:52:32 +0000 Gerrit-HasComments: Yes
