Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24334 )
Change subject: IMPALA-15027: Python 2 infra cleanup ...................................................................... Patch Set 6: Code-Review+1 (2 comments) Thanks for putting this together. This looks good to me, just a couple nits. http://gerrit.cloudera.org:8080/#/c/24334/6/bin/generate_xml_config.py File bin/generate_xml_config.py: http://gerrit.cloudera.org:8080/#/c/24334/6/bin/generate_xml_config.py@114 PS6, Line 114: """Handle module import differences between Python2 and Python3""" Nit: We can update this comment http://gerrit.cloudera.org:8080/#/c/24334/6/infra/python/bootstrap_virtualenv.py File infra/python/bootstrap_virtualenv.py: http://gerrit.cloudera.org:8080/#/c/24334/6/infra/python/bootstrap_virtualenv.py@33 PS6, Line 33: # This module can be run with python >= 2.7. It makes no guarantees about usage on : # python < 2.7. Nit: We can update this comment -- To view, visit http://gerrit.cloudera.org:8080/24334 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b43878bafa488d513b4440aab3865cb17b12c78 Gerrit-Change-Number: 24334 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 28 May 2026 20:31:30 +0000 Gerrit-HasComments: Yes
