Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10823 )
Change subject: IMPALA-7190: Remove unsupported format writer support ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Some minor comments for tests, otherwise lgtm. http://gerrit.cloudera.org:8080/#/c/10823/1/tests/query_test/test_compressed_formats.py File tests/query_test/test_compressed_formats.py: http://gerrit.cloudera.org:8080/#/c/10823/1/tests/query_test/test_compressed_formats.py@150 PS1, Line 150: def test_unsupported_writers(self, vector): I would prefer to use unique_database, and remove the drops from unsupported-writers.test http://gerrit.cloudera.org:8080/#/c/10823/1/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/10823/1/tests/shell/test_shell_interactive.py@a404 PS1, Line 404: This line could be left here, but check that "... not in result.stduot". This would make it easier to restore the original test when there will be new deprecated query options. -- To view, visit http://gerrit.cloudera.org:8080/10823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I821dc7495a901f1658daa500daf3791b386c7185 Gerrit-Change-Number: 10823 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 27 Jun 2018 13:13:50 +0000 Gerrit-HasComments: Yes
