Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24159 )
Change subject: IMPALA-14863: Fixes Potential OOM During Row Batch Processing ...................................................................... Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/24159/14/be/src/exec/partitioned-hash-join-node-ir.cc File be/src/exec/partitioned-hash-join-node-ir.cc: http://gerrit.cloudera.org:8080/#/c/24159/14/be/src/exec/partitioned-hash-join-node-ir.cc@60 PS14, Line 60: ClearExprResultsPool(); > The latest implementation seems simpler. So I'm not sure where this discuss It's possible for a SQL to have a billion duplicates on the build side. That means the memory usage for processing a single probe row can still be very large, so I'd prefer an approach that evaluates more often than once per probe row. -- To view, visit http://gerrit.cloudera.org:8080/24159 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic54b5c39e1388681275681f22e61b27728dba5af Gerrit-Change-Number: 24159 Gerrit-PatchSet: 14 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 28 May 2026 22:45:48 +0000 Gerrit-HasComments: Yes
