Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10815 )
Change subject: IMPALA-7205: Respond to ReportExecStatus() RPC with CANCELLED if query execution has terminated ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/10815/1/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/10815/1/be/src/runtime/coordinator-backend-state.cc@366 PS1, Line 366: rpc_status = DebugAction(query_ctx.client_request.query_options, Wouldn't we need to break; the loop if this was not ok()? http://gerrit.cloudera.org:8080/#/c/10815/1/be/src/runtime/coordinator-backend-state.cc@367 PS1, Line 367: COORD_CANCEL_QUERY_FINSTANCES_RPC Should we name this actions so that it's clear that it's in the sender side of the rpc? http://gerrit.cloudera.org:8080/#/c/10815/1/tests/query_test/test_cancellation.py File tests/query_test/test_cancellation.py: http://gerrit.cloudera.org:8080/#/c/10815/1/tests/query_test/test_cancellation.py@139 PS1, Line 139: if fail_rpc_action != None: If wait_action != None and fail_rpc_action == None, then debug_action will and in a "|". You could do this instead: debug_action = "|".join(filter(None, [wait_action, fail_rpc_action])) http://gerrit.cloudera.org:8080/#/c/10815/1/tests/query_test/test_cancellation.py@206 PS1, Line 206: if wait_action is None and fail_rpc_action is None \ Then this could be "if not debug_action and ('count'..." -- To view, visit http://gerrit.cloudera.org:8080/10815 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7bb2c26edace89853f14a329f891d1f9a065a991 Gerrit-Change-Number: 10815 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Wed, 27 Jun 2018 21:43:28 +0000 Gerrit-HasComments: Yes
