Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24372 )

Change subject: IMPALA-15043: Add Kubernetes-in-Docker E2E scripts
......................................................................


Patch Set 10:

(4 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24372/10/bin/jenkins/run-k8s-e2e-tests.sh
File bin/jenkins/run-k8s-e2e-tests.sh:

http://gerrit.cloudera.org:8080/#/c/24372/10/bin/jenkins/run-k8s-e2e-tests.sh@113
PS10, Line 113:   CREATE_CLUSTER_CMD=(k3d cluster create 
"${K8S_E2E_K3D_CLUSTER_NAME}" --servers 1 --agents 0 --wait)
line too long (101 > 90)


http://gerrit.cloudera.org:8080/#/c/24372/10/bin/jenkins/run-k8s-e2e-tests.sh@132
PS10, Line 132:     -l 
"app.kubernetes.io/instance=${K8S_E2E_RELEASE_NAME},app.kubernetes.io/name=impala"
 \
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/24372/10/bin/jenkins/run-k8s-e2e-tests.sh@150
PS10, Line 150:     -l 
"app.kubernetes.io/instance=${K8S_E2E_RELEASE_NAME},app.kubernetes.io/name=impala,app.kubernetes.io/component=impalad"
 \
line too long (127 > 90)


http://gerrit.cloudera.org:8080/#/c/24372/10/bin/run-k8s-e2e-tests.sh
File bin/run-k8s-e2e-tests.sh:

http://gerrit.cloudera.org:8080/#/c/24372/10/bin/run-k8s-e2e-tests.sh@94
PS10, Line 94:       -o go-template='{{range $k, $v := .spec.selector}}{{printf 
"%s=%s," $k $v}}{{end}}' \
line too long (91 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/24372
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I122b99c38c8c70ab535349f92212621330f2aa55
Gerrit-Change-Number: 24372
Gerrit-PatchSet: 10
Gerrit-Owner: Anubhav Jindal <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Fri, 29 May 2026 09:56:37 +0000
Gerrit-HasComments: Yes

Reply via email to