Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23805 )
Change subject: IMPALA-14637: COMMIT_TXN events should trigger reload for truncate ops ...................................................................... Patch Set 7: (2 comments) Thanks for the review! http://gerrit.cloudera.org:8080/#/c/23805/5/fe/src/main/java/org/apache/impala/catalog/TableWriteEvent.java File fe/src/main/java/org/apache/impala/catalog/TableWriteEvent.java: http://gerrit.cloudera.org:8080/#/c/23805/5/fe/src/main/java/org/apache/impala/catalog/TableWriteEvent.java@26 PS5, Line 26: > nit: or ABORT_TXN Done http://gerrit.cloudera.org:8080/#/c/23805/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/23805/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2041 PS5, Line 2041: // forcing file metadata reload so that new files (due to insert) are reflected : // Hdf > nit: we can combine these two if conditions into a single one and remove th I think the else-part is still helpful since there are no logs indicating the AlterTable event is a truncate operation. Now we clearly log such truncate events. -- To view, visit http://gerrit.cloudera.org:8080/23805 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89aac12819f08dd9ed42d5d8b21a96c04b04d75c Gerrit-Change-Number: 23805 Gerrit-PatchSet: 7 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 01 Jun 2026 06:18:56 +0000 Gerrit-HasComments: Yes
