Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24376 )
Change subject: IMPALA-12696: Update HS2 definitions (TCLIService.thrift) ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/24376/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24376/5//COMMIT_MSG@9 PS5, Line 9: since 2022) > nit: since Done http://gerrit.cloudera.org:8080/#/c/24376/5//COMMIT_MSG@9 PS5, Line 9: i > nit: capital L Done http://gerrit.cloudera.org:8080/#/c/24376/5/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/24376/5/be/src/service/impala-hs2-server.cc@1361 PS5, Line 1361: c void SetNotImplement > nit: why not SetNotImplementedError (with capital S)? Done http://gerrit.cloudera.org:8080/#/c/24376/5/be/src/service/impala-hs2-server.cc@1361 PS5, Line 1361: stat > Could be a static function. Done -- To view, visit http://gerrit.cloudera.org:8080/24376 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc Gerrit-Change-Number: 24376 Gerrit-PatchSet: 6 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 01 Jun 2026 14:59:47 +0000 Gerrit-HasComments: Yes
