Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24346 )
Change subject: IMPALA-15036: Set HTTP port for minicluster Trino in a more robust way ...................................................................... Patch Set 1: Code-Review+2 > Patch Set 1: > > > I wonder if we can skip the building part altogether; the only tricky part > > is pushing the $USER to the container, also, the run-trino.sh could use a > > static config.properties that contains the port number setting. > > It's probably doable, but we would have a static config.properties file that > might become obsolete for newer Trino versions. I don't feel strongly against > it, so I can implement it that way if you think it's a better approach. I think the base config for Trino is not changing that fast and we can adapt it pretty fast here as it's not a dependency yet. As the scope of this change is limited for just to the HTTP port setting, I'll +2 it, maybe later we can go with the no-build version -- To view, visit http://gerrit.cloudera.org:8080/24346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If8e1300694200aaaf675675fb348f0c767e6c147 Gerrit-Change-Number: 24346 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 02 Jun 2026 05:51:35 +0000 Gerrit-HasComments: No
