Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24375 )
Change subject: IMPALA-14838: Count open deferred RPC intervals ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/24375/2/be/src/runtime/krpc-data-stream-recvr.cc File be/src/runtime/krpc-data-stream-recvr.cc: http://gerrit.cloudera.org:8080/#/c/24375/2/be/src/runtime/krpc-data-stream-recvr.cc@56 PS2, Line 56: class DeferredRpcsTimeTracker { > Did you look at ConcurrentTimerCounter? It is backed by ConcurrentStopWatch Done in the latest patch set. I switched TotalHasDeferredRPCsTime to RuntimeProfile::ConcurrentTimerCounter, so the underlying ConcurrentStopWatch keeps the timer running while any sender queue has deferred_rpcs_ non-empty. That also avoids double-counting overlapping intervals across sender queues. -- To view, visit http://gerrit.cloudera.org:8080/24375 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5efe8016b268e3707a2b7b99c488de69ccdad8e6 Gerrit-Change-Number: 24375 Gerrit-PatchSet: 2 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 03 Jun 2026 09:21:42 +0000 Gerrit-HasComments: Yes
